Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3314

Open
wants to merge 3 commits into
base: v3/master
Choose a base branch
from

Conversation

ElevationsRPG
Copy link

@ElevationsRPG ElevationsRPG commented Dec 11, 2024

Update Windows README to use latest conan version 2.10.2

what

Update the README file for windows builds

why

Because it asks to install out of date conan version which can result in libiconv errors when compiling for 32-bit

references

#3313

Update Windows README to use latest conan version and conan center.
@eduar-hte
Copy link
Contributor

eduar-hte commented Dec 11, 2024

Please update the Conan version in the Dockerfile as well so that it's in sync with the Win32 build instructions.

AFAIK, the 'Conan Center' change is unrelated to the 32-bit build issue.

Update Docker to latest conan version 2.10.2
@ElevationsRPG
Copy link
Author

Please update the Conan version in the Dockerfile as well so that it's in sync with the Win32 build instructions.

AFAIK, the 'Conan Center' change is unrelated to the 32-bit build issue.

I have updated the docker file to use version 2.10.2

if you like i can remove the conan center change although i think it would be recommended to make sure people are downloading correct remotes for future builds right?

@eduar-hte
Copy link
Contributor

if you like i can remove the conan center change although i think it would be recommended to make sure people are downloading correct remotes for future builds right?

I'd favor keeping the build steps minimal, to cover just what is required to build the library, and leave the defaults setup by the Conan installer.

BTW, the default Conan Center for Conan 2 seems to actually be https://center2.conan.io since version 2.9.2, see conan-io/conan-center-index@74bc767

Remove conan center change
@ElevationsRPG
Copy link
Author

if you like i can remove the conan center change although i think it would be recommended to make sure people are downloading correct remotes for future builds right?

I'd favor keeping the build steps minimal, to cover just what is required to build the library, and leave the defaults setup by the Conan installer.

BTW, the default Conan Center for Conan 2 seems to actually be https://center2.conan.io since version 2.9.2, see conan-io/conan-center-index@74bc767

Oh i thought i used that one guess i didnt, Anyway i've removed the conan center changes in the readme.md file

@airween
Copy link
Member

airween commented Dec 18, 2024

@eduar-hte
Copy link
Contributor

eduar-hte commented Dec 18, 2024

https://github.com/owasp-modsecurity/ModSecurity/actions/runs/12270940148/job/34610196548?pr=3314#step:2:182

This one appears to show that geoip is no longer available in Homebrew, and that may be breaking the step that installs dependencies:

Error: geoip has been disabled because it has an archived upstream repository! It was disabled on 2024-12-12.

https://github.com/owasp-modsecurity/ModSecurity/actions/runs/12270940148/job/34241868930?pr=3314#step:5:6

Not sure about this one, it seems build.sh already failed, so the underlying issue is before the configure step.

@airween
Copy link
Member

airween commented Dec 18, 2024

https://github.com/owasp-modsecurity/ModSecurity/actions/runs/12270940148/job/34610196548?pr=3314#step:2:182

This one appears to show that geoip is no longer available in Homebrew, and that may be breaking the step that installs dependencies:

Error: geoip has been disabled because it has an archived upstream repository! It was disabled on 2024-12-12.

https://github.com/owasp-modsecurity/ModSecurity/actions/runs/12270940148/job/34241868930?pr=3314#step:5:6

Not sure about this one, it seems build.sh already failed, so the underlying issue is before the configure step.

Thanks! I try to figure out what can we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants